Repository navigation
feat(predictor): default to ONNX on non-ARM hosts - #429
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #429 +/- ##
========================================
Coverage 79.46% 79.46%
========================================
Files 6 6
Lines 852 852
========================================
Hits 677 677
Misses 175 175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Interesting! Can you share more data of your benchmark to have a better informed decision? Excellent initiative either way! I can also open the opportunity to have different docker depending on the target architecture (NCNN installed when ARM, onnx when AMD64) |
|
Thanks @frgfm ! I measured the 1.5x while setting up the engine on the Argentinian VM, but honestly that's not really the point here. The code already logged that ONNX is recommended on non ARM hosts and kept NCNN anyway, so this just follows that advice. |
Classifiernow defaults to NCNN on ARM and ONNX elsewhere. An explicitformatis still honored.