Repository navigation
feat(engine): one heartbeat per camera per minute - #420
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #420 +/- ##
===========================================
+ Coverage 79.46% 80.02% +0.56%
===========================================
Files 6 6
Lines 852 846 -6
===========================================
Hits 677 677
+ Misses 175 169 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The SIGALRM cutoff could fire inside urllib3 and deadlock it (kwartier-west, 2026-09-11). pyroclient now takes a per-call heartbeat timeout (pyronear/pyro-api#691), so the engine passes timeout=1 and catches any RequestException. Bumps pyroclient to the merged revision.
MateoLostanlen
force-pushed
the
feat/heartbeat-per-camera
branch
from
October 8, 2026 16:19
df1a5d0 to
b47eee4
Compare
An unknown camera IP raised KeyError in predict and aborted inference for that frame.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
heartbeat_period(default 60 s), tracked per camera IP on a monotonic clock. Periodic image uploads and mask fetches are unchanged.timeout=1), with anyRequestExceptionlogged. SIGALRM could fire inside urllib3 and deadlock it (kwartier-west, 2026-09-11). Note this bounds connect and each read, not total wall time (DNS is not covered).