馃摑 docs(security): sync threat model with merged fixes - #3312
Merged
Merged
Conversation
pypa#3301 and pypa#3306 merged, but the threat model still listed both as open work and named GH_RELEASE_TOKEN as the credential that pushes the release commit, tag and get-virtualenv update. Name the release GitHub App as that credential and as a ruleset bypass actor, record the PEP 751 lock as the zipapp's dependency control, keep one open item for revoking the old personal access token after the first App-based release, and link pypa#3311 from the reproducibility item.
gaborbernat
added
documentation
security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The threat model merged in #3294 while #3301 and #3306 were still open, so it lists both as pending work. 馃摑 It also names
GH_RELEASE_TOKENas the credential that pushes the release commit, the tag and the get-virtualenv update, which the release GitHub App now does with short-lived tokens.The assets list, the release data-flow diagram, the S1 discussion and the accepted risks now name the App and its place as a ruleset bypass actor. The T5 mitigation records that the zipapp bundles versions a PEP 751 lock pins by SHA-256, refreshed after the seven-day cooldown. One open item stays for the old personal access token: it remains in the
releaseenvironment until a release built with App tokens succeeds, and then a maintainer revokes it. The reproducibility item links #3311.