fix(sbom): preserve format and reproducibility - #3278
Merged
Merged
Conversation
gaborbernat
force-pushed
the
fix/sbom-review
branch
from
September 21, 2026 23:57
c04493f to
775c5e8
Compare
gaborbernat
added
the
security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SBOM hook added in #3270 splits wheel
RECORDrows on commas, which breaks valid CSV paths containing commas or quoted newlines. It also declares unresolved runtime dependencies as leaves, although CycloneDX uses an empty dependsOn list to mean that a component has no dependencies.Parse
RECORDas CSV and omit dependency entries where the transitive graph is unknown. Keep the root edges and incomplete composition, and allow those unknown relationships in the validator.Use Hatchling's reproducible timestamp for the SBOM and recorded build input. Leave CI run identifiers in release attestations instead of embedding them in wheel content, and read the source revision from the checkout rather than a downstream builder's
GITHUB_SHA.