test: avoid filtering compatible release examples - #1407
Open
LouisDeconinck wants to merge 1 commit into
Open
LouisDeconinck wants to merge 1 commit into
LouisDeconinck wants to merge 1 commit into
Conversation
Signed-off-by: Louis Deconinck <louis.dck@gmail.com> Assisted-by: Codex
3 tasks
|
In case a human reviewer doesn't notice, there's also #1409. |
Author
|
Thanks @rossburton — I hadn't spotted #1409. For reviewers comparing the two: this PR removes the Happy either way — if #1409 lands first I'm fine closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1406.
The compatible-release property test discarded candidates with a different epoch via assume. Because the generated versions often had different epochs, Hypothesis could intermittently fail its filtering health check.
Generate the specifier and candidate with the same epoch instead. This preserves coverage of epoch-bearing versions while removing the rejection that caused intermittent failures.
Checks:
Assisted by Codex via the commit trailer.