fix: handle relative index URLs without panicking - #249
Open
giri256 wants to merge 1 commit into
Open
Conversation
Signed-off-by: p1 <giridharpavan593@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #210
download_vidx()parsed each index URL withunwrap(). A relative URL therefore panicked the update worker before the surrounding retry-and-skip logic could handle the malformed entry.This propagates the URL parse error through the function's existing
Resultinstead. The caller can then retry and eventually ignore the bad URL without aborting the whole index update.The regression test reproduces the previous
RelativeUrlWithoutBasepanic and verifies that the same input now returns an error.Verification:
cargo test -p cmsis-pack update::download::tests::relative_vidx_url_returns_error -- --exactcargo fmt --all -- --check