Skip to content

tests/test_general.py:test_3569(): fix failure with mupdf master. #5121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julian-smith-artifex-com merged 2 commits into from
Sep 15, 2026
+10 −8
Merged

tests/test_general.py:test_3569(): fix failure with mupdf master. #5121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfa9262
tests/test_general.py:test_3569(): fix failure with mupdf master.
julian-smith-artifex-com Sep 15, 2026
e69abab
tests/: fixed some tests with current mupdf-1.28.x
julian-smith-artifex-com Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/test_general.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1720,7 +1720,9 @@ def test_3569():
'</svg>\n'
)
wt = pymupdf.TOOLS.mupdf_warnings()
if pymupdf.mupdf_version_tuple >= (1, 28):
if pymupdf.mupdf_version_tuple >= (1, 29):
assert wt == 'unknown cid collection: PDFAUTOCAD-Indentity0\nnon-embedded font using identity encoding: ArialMT (mapping via Adobe-Identity-UCS)\ninvalid marked content sequence / clip nesting'
elif pymupdf.mupdf_version_tuple >= (1, 28):
assert wt == 'unknown cid collection: PDFAUTOCAD-Indentity0\nnon-embedded font using identity encoding: ArialMT (mapping via )\ninvalid marked content sequence / clip nesting'
else:
assert wt == 'unknown cid collection: PDFAUTOCAD-Indentity0\nnon-embedded font using identity encoding: ArialMT (mapping via )\ninvalid marked content and clip nesting'
Expand Down Expand Up @@ -2277,7 +2279,7 @@ def test_5054():
text2 = page.get_text()
print(f'{text1=}')
print(f'{text2=}')
if pymupdf.mupdf_version_tuple < (1, 29):
if pymupdf.mupdf_version_tuple < (1, 28, 6):
assert text2 != text1
else:
assert text2 == text1
Expand Down
4 changes: 1 addition & 3 deletions tests/test_pixmap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,9 +806,7 @@ def test_5082():
except subprocess.TimeoutExpired:
timeout = True
print(f'test_5082(): {timeout=}')
# As of 2026-08-18 we expect timeout with 1.28.x (currently 1.28.3) and
# earlier.
if pymupdf.mupdf_version_tuple <= (1, 28, 4):
if pymupdf.mupdf_version_tuple < (1, 28, 6):
assert timeout, f'Expected timeout from {pymupdf.mupdf_version=}.'
else:
assert not timeout, f'Unexpected timeout from {pymupdf.mupdf_version=}.'
8 changes: 5 additions & 3 deletions tests/test_widgets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,11 +546,14 @@ def test_5101():
path = os.path.normpath(f'{__file__}/../../tests/resources/test_5101.pdf')
with pymupdf.open(path) as document:
print(f'{len(document)=}')
if pymupdf.mupdf_version_tuple >= (1, 29):
if pymupdf.mupdf_version_tuple >= (1, 28, 6):
page = document[0]
wt = pymupdf.TOOLS.mupdf_warnings()
print(f'{wt=}')
assert wt == 'cycle in parent chain\nfixed bad Parent in AcroForm tree\n... repeated 2 times...'
if pymupdf.mupdf_version_tuple >= (1, 29):
assert wt == 'cycle in parent chain\nfixed bad Parent in AcroForm tree\n... repeated 2 times...'
else:
assert wt == 'fixed bad Parent in AcroForm tree\n... repeated 2 times...'
document2 = pymupdf.open()
document2.insert_pdf(document, annots=False, widgets=False, links=True)
else:
Expand Down Expand Up @@ -657,4 +660,3 @@ def get_acro_names(document):

assert num_still_present == 0, f'{num_still_present=}'
assert num_still_present_acro == 0, f'{num_still_present_acro=}'

Loading