Lift assumptions into scan inner function#2172
Draft
jessegrabowski wants to merge 4 commits into
Draft
Conversation
scan_delegate propagates matrix-property facts through a Scan node during inference. lift_assumptions_into_scan is a scan_seqopt1 rewrite that re-asserts a Scan's outer-input assumptions on the inner graph, so assumption-driven rewrites of the loop body can fire. Wired in via assumptions/__init__.py.
ricardoV94
reviewed
May 26, 2026
Member
ricardoV94
left a comment
ricardoV94
left a comment
There was a problem hiding this comment.
look like a great start. Would be nice to look at a grad case where outputs get flipped and become sequences of the grad scan
|
|
||
|
|
||
| @node_rewriter([Scan]) | ||
| def lift_assumptions_into_scan(fgraph, node): |
Member
There was a problem hiding this comment.
I prefer inline/lower/sink. Lift sounds to me like inside->out.
But into kinda specifies it. Some move...into is perhaps the best
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.wip