Fix cycle error in FusionOptimizer#2171
Closed
jaanerik wants to merge 1 commit into
Closed
Conversation
…s and bitset corruption
Member
|
I can't reproduce the issue and the tests were passing fine on main. Closing this, feel free to comment on the original issue if you have a working failing example |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix cycle error in FusionOptimizer by preventing overlapping subgraphs and bitset corruption
Description
This PR addresses a structural regression in FusionOptimizer (introduced in recent ordering changes) where certain complex topologies or multi-output subgraphs could trigger a ValueError: graph contains cycles during the final topological sort of discovered subgraphs.
The Problem:
Related Issue
Checklist
Type of change