Skip to content

docs(upstream): record recovered adoptions and remaining review work #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rynfar merged 2 commits into from
Sep 6, 2026
Merged

docs(upstream): record recovered adoptions and remaining review work #284

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c7f77d
docs(upstream): record recovered adoptions and remaining review work
rynfar Sep 6, 2026
9418b66
docs(upstream): link the catch-up release receipts
rynfar Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 59 additions & 5 deletions .agents/upstream-review.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,60 @@ Two standing sections outlive any single batch and must be read on every review:

## Review batches

## 2026-09-06 — finish earlier approved adoption (partial)

The maintainer asked to finish earlier adopted work and continue the catch-up.
The recovered work comprises the still-open PR hub and Astra PRs, the interrupted
OpenCode approval/Stop series, and the older OpenCode task-progress intent in #178.
Upstream was refreshed through `bfba7781681eaa03eb465ce3d9a4ec07bf952b78`.
The full review cursor remains `beae2147a9487ec47ac992319f2216914b4cb62d`.

| Concern | Upstream commits | Pylon outcome |
| --------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| Astra model classification and public feeds | #9762 `bc03c3640d6d3bb44e5fb477bfd78d7484cd0e00` | #270 merged; #280 repairs checkout. Publication run 34010607556 succeeded; both public feeds at pylon-releases `4f071d502a24cb2b86cf4b44efb4f543c7a777cd` exactly match the validated source. |
| Cached desktop resource monitor | #9184 `7a8df3338f910cd18543cd3ea98b8b10385e8dcd` | Split from #269, merged as #281 with green CI. |
| OpenCode approvals, output, Stop, and task progress | #9005 `62d39bf00d5ddd83a9b36a81321fe9aa4d2502bb`; #9282 `d2b6f3b9296f682c6158b894ab33d98d0c4bfb2b`; #9653 `01f3e50eca5102ccd881de6f942a98fe6a518ad4` | #283 merged with green CI as `fa6da65b1444321810e77a9aa714d72c1920ba80`; #178 closed as superseded. |
| PR hub controls and retained details | #9188 `443b4ebfe83fcfe64c34b09ecb5a5fffdebb85c7`; #9334 `2a3cfe456375fd34b906f849b04706109dc74170`; #9294 `d897641d738c67dd7c12cbb3a273b43fe17a5eb1` | #269 rebased and verified; green CI. Browser permission or an explicit visual-evidence waiver remains pending. |
| Chat scroll-to-end visibility | #9280 `c742edd46c5b6792ec8647f934a4703f9103aa82` | Split from #269 into #282; green CI. Browser/video permission or an explicit evidence waiver remains pending. |

OpenCode preserves Pylon's incarnation and admission fencing and compaction events.
Workspace permission scope uses the existing detail field on all clients, without
importing upstream's incompatible approval-option field. Plans are parent-only,
active-turn-only, deduplicated, and omit cancelled tasks. The output-drain regression
uses a real subprocess; the legacy turn fixture now follows Pylon's admitted start
path. All 400 focused tests pass across nine files; server, web, mobile, and shared
client-runtime typechecks, targeted lint, and formatting pass.

PR hub verification includes 612 tests and all six affected package typechecks.
Pylon-specific regressions prevent denied browser storage from crashing the detail
panel and prevent a cached PR from crossing environment boundaries. The scrolling
fix passes 44 tests and web typecheck; the desktop build fix passes 78 tests and
scripts typecheck. No browser, simulator, live provider session, or production
state was used in these checks.

The original 555-commit inventory now has five further upstream commits (560 total).
All eight selected commits inside that range were originally unmatched; #9005 is
an older missing dependency outside the range. After those eight land, 448 remain
unselected for assessment. Four selected UI commits are still pending separately;
they are not silently marked landed. Inventory evidence is not a claim that every
upstream change belongs in Pylon.

The preceding catch-up batch shipped successfully as Nightly
`0.0.33-nightly.20260906.120` from `9a4b54165743dd55376c45043ea071bc1c1bfc96`
(release run 34007254669); this closes the earlier publication check. Nightly
`0.0.33-nightly.20260906.121` targets the new server/build changes from
`fa6da65b1444321810e77a9aa714d72c1920ba80`. Its build and publication receipts
are tracked by release run 34011039725 and #284; the two pending UI PRs are excluded.

Deferred/watch recheck: DEF-7 remains not yet (November 1 floor; no preview-workflow
changes). DEF-8 is due after Expo 57 #171. Recommend its dev-loop half first, keeping
Pylon schemes, production/preview fingerprints, and current Tailwind 4.3.0; review
#9355 before any Tailwind 4.3.3 adoption with Uniwind 1.11. Keep native-menu, navigation,
and shared connection-scope work separate for native verification. No new approval
is inferred. WATCH-1 #8097 remains open/unmerged; owner #114 records that #283 closed
the OpenCode gap and superseded #178. WATCH-2 #6573 and WATCH-3 #7966/#7986 remain closed with no replacement
in the newly checked paths, retaining their November 1 floors. No entries were added.

## 2026-09-05 — targeted Astra model classification

The maintainer directed completing the Astra integration after review identified
Expand Down Expand Up @@ -3413,8 +3467,8 @@ an entry comes due, is rewritten, or is retired, update the owning issue in the
same change. An owner that disagrees with this table is the failure this list
exists to prevent.

| ID | Owner | Upstream | Added | Current signal | Revisit when | Response to evaluate |
| ------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------- | ---------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| WATCH-1 | [#114](https://github.com/pylon-code/pylon/issues/114) — Prime provider parity | #8097 (PR, open and ready for review) — restore composer tasks after relaunch | 2026-08-29 | Rechecked 2026-09-05. Upstream #5760 closed on September 4 without an identified linked fix; closing it does not resolve Pylon's OpenCode task gap, still owned by open Pylon #178. Retire that closed issue as an upstream watch target. #8097 remains unmerged and is superseded in Pylon by #137, whose task restoration also retains waiting steps. | Revisit only if #8097 merges and diverges from Pylon's approach: `gh pr view 8097 --repo pingdotgg/t3code --json state,mergedAt`. Review any migration against Pylon's current manifest; never reuse upstream numbering. | Do not port #8097 wholesale. Consider a plan-activity index only if current query plans demonstrate a need. Review unrelated `turn.aborted` changes separately. |
| WATCH-2 | [`#174`](https://github.com/pylon-code/pylon/issues/174) — cross-thread messaging design; context in [`#114`](https://github.com/pylon-code/pylon/issues/114) | `#6573` (PR) — authenticated cross-thread MCP tools | 2026-08-29 | **Premise gone.** Closed unmerged 2026-08-28 without adding permission splitting or bounded read-only tools. Nothing upstream to compare against today. | A replacement lands. Check `git log --oneline <cursor>..t3code-upstream/main -- apps/server/src/mcp/toolkits/` and `gh pr list --repo pingdotgg/t3code --search 'mcp thread tools' --state merged`. Not before 2026-11-01 — upstream abandoned this once and a rewrite is not a weekly event. | Compare with Pylon's scoped read-only context/checkpoint MCP design before adoption. Do not revive `#6573` itself. |
| WATCH-3 | [`#177`](https://github.com/pylon-code/pylon/issues/177) — scheduled-run safety contract; context in [`#114`](https://github.com/pylon-code/pylon/issues/114) | `#7966` (issue) / `#7986` (PR) — server-side scheduled agent runs | 2026-08-29 | **Premise gone.** Both closed 2026-08-28; `#7986` closed unmerged. The implementation Pylon declined to cherry-pick no longer exists upstream. | A replacement scheduling implementation merges. Check `git log --oneline <cursor>..t3code-upstream/main -- apps/server/src/orchestration/Layers/TaskFireReactor.ts apps/server/src/orchestration/Layers/OrchestrationReactor.ts`. Not before 2026-11-01. | Fresh review only. Pylon's own canonical scheduled-turn ownership question in `#114` is unblocked by upstream's retreat, not answered by it. |
| ID | Owner | Upstream | Added | Current signal | Revisit when | Response to evaluate |
| ------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------- | ---------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| WATCH-1 | [#114](https://github.com/pylon-code/pylon/issues/114) — Prime provider parity | #8097 (PR, open and ready for review) — restore composer tasks after relaunch | 2026-08-29 | Rechecked 2026-09-06. Upstream #9653 fixes the OpenCode task gap tracked by closed issue #5760. Pylon adopted it with the approval/Stop dependency series in #283 and closed task-only #178 as superseded. #8097 remains open/unmerged and overlaps Pylon #137, which retains waiting steps. | Revisit only if #8097 merges and diverges from Pylon's approach: `gh pr view 8097 --repo pingdotgg/t3code --json state,mergedAt`. Review any migration against Pylon's current manifest; never reuse upstream numbering. | Do not port #8097 wholesale. Consider a plan-activity index only if current query plans demonstrate a need. Review unrelated `turn.aborted` changes separately. |
| WATCH-2 | [`#174`](https://github.com/pylon-code/pylon/issues/174) — cross-thread messaging design; context in [`#114`](https://github.com/pylon-code/pylon/issues/114) | `#6573` (PR) — authenticated cross-thread MCP tools | 2026-08-29 | **Premise gone.** Closed unmerged 2026-08-28 without adding permission splitting or bounded read-only tools. Nothing upstream to compare against today. | A replacement lands. Check `git log --oneline <cursor>..t3code-upstream/main -- apps/server/src/mcp/toolkits/` and `gh pr list --repo pingdotgg/t3code --search 'mcp thread tools' --state merged`. Not before 2026-11-01 — upstream abandoned this once and a rewrite is not a weekly event. | Compare with Pylon's scoped read-only context/checkpoint MCP design before adoption. Do not revive `#6573` itself. |
| WATCH-3 | [`#177`](https://github.com/pylon-code/pylon/issues/177) — scheduled-run safety contract; context in [`#114`](https://github.com/pylon-code/pylon/issues/114) | `#7966` (issue) / `#7986` (PR) — server-side scheduled agent runs | 2026-08-29 | **Premise gone.** Both closed 2026-08-28; `#7986` closed unmerged. The implementation Pylon declined to cherry-pick no longer exists upstream. | A replacement scheduling implementation merges. Check `git log --oneline <cursor>..t3code-upstream/main -- apps/server/src/orchestration/Layers/TaskFireReactor.ts apps/server/src/orchestration/Layers/OrchestrationReactor.ts`. Not before 2026-11-01. | Fresh review only. Pylon's own canonical scheduled-turn ownership question in `#114` is unblocked by upstream's retreat, not answered by it. |
Loading