Repository navigation
fix(mcp): pin mcp below 2 and say when the installed mcp is unsupported - #6
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pip install 'prescale[mcp]'now resolves mcp 2.x, which renamedFastMCP, soprescale mcpcan't start. Worse, it then tells the user to installprescale[mcp], the thing they already have, and following that reinstalls 2.x. This pins the extra tomcp>=1.0,<2. If an unsupported mcp is already installed, the command now names the real cause and the command that fixes it. CI now installs the extra, so the MCP server test actually runs instead of skipping; that's why CI never caught this.How it was verified
prescale mcp→MCP support needs the optional extra. Install it with: pip install 'prescale[mcp]'Error: the installed mcp package isn't supported: No module named 'mcp.server.fastmcp'. This is mcp 2.x…followed bypip install 'mcp>=1.0,<2'pip install -e "cli[dev,mcp]"resolves mcp 1.30.0; a real MCPinitializeover stdio returnsserverInfo: {"name": "prescale", …}ruff check cli/src: All checks passed! ·pytest cli/tests -q: 235 passed (a new test covers the unsupported-mcp message)Risk
Tier: standard · Public surface: the
mcpextra's version range, and one error message. Reaches users with the next release (1.1.4). Someone running another tool that needs mcp 2.x in the same environment would get a resolver conflict; supporting mcp 2.x is a separate change. Rollback: revert this PR.Generated by Claude Code