Skip to content

fix(mcp): pin mcp below 2 and say when the installed mcp is unsupported - #6

Merged
pyjeebz merged 1 commit into
mainfrom
fix/pin-mcp-v1
Nov 2, 2026
Merged

pyjeebz merged 1 commit into
mainfrom
fix/pin-mcp-v1

Conversation

@pyjeebz

@pyjeebz pyjeebz commented Nov 2, 2026

Copy link
Copy Markdown
Owner

pip install 'prescale[mcp]' now resolves mcp 2.x, which renamed FastMCP, so prescale mcp can't start. Worse, it then tells the user to install prescale[mcp], the thing they already have, and following that reinstalls 2.x. This pins the extra to mcp>=1.0,<2. If an unsupported mcp is already installed, the command now names the real cause and the command that fixes it. CI now installs the extra, so the MCP server test actually runs instead of skipping; that's why CI never caught this.

How it was verified

  • Before, with mcp 2.3.0 installed: prescale mcp → MCP support needs the optional extra. Install it with: pip install 'prescale[mcp]'
  • After, same environment: Error: the installed mcp package isn't supported: No module named 'mcp.server.fastmcp'. This is mcp 2.x… followed by pip install 'mcp>=1.0,<2'
  • pip install -e "cli[dev,mcp]" resolves mcp 1.30.0; a real MCP initialize over stdio returns serverInfo: {"name": "prescale", …}
  • ruff check cli/src: All checks passed! · pytest cli/tests -q: 235 passed (a new test covers the unsupported-mcp message)

Risk

Tier: standard · Public surface: the mcp extra's version range, and one error message. Reaches users with the next release (1.1.4). Someone running another tool that needs mcp 2.x in the same environment would get a resolver conflict; supporting mcp 2.x is a separate change. Rollback: revert this PR.



Generated by Claude Code

Copilot AI balanced review requested due to automatic review settings November 2, 2026 06:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@pyjeebz
pyjeebz merged commit d00073c into main Nov 2, 2026
3 checks passed
@pyjeebz pyjeebz mentioned this pull request Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants