Repository navigation
feat(journeys): the diagnosis in CI and the HTML report, plus a fix prompt for coding agents - #13
Merged
Merged
Conversation
…rompt for coding agents
…en, safe Server text, honest Copy
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#12 made
investigatesay why a journey step breaks. This PR adds two things:Fix prompt (
fix_prompt, new Result field). Every diagnosis, for URL runs and journey runs, now carries a prompt like this, from a real run on the example shop:fixprompt.py), with no model.user:password@, the query and the fragment.***(a preview'sx-vercel-protection-bypass,?token=).Serverheader is cut down to a short product token, so the app can't put instructions into the prompt.--journey NAME--urls --path /routefor URL runsWhere it shows:
investigateprints it as plain text, with no box, so it copies cleanly.--jsonand saved runs: in thefix_promptfield.show --html): a new Diagnosis section (evidence, fixes, the prompt) with a Copy button. If the browser refuses the clipboard, the button says "Select and copy".investigatereturns it.prescale cinow diagnoses journey runs, as it already did URL runs. The PR comment shows the diagnosed step, Why, Evidence (journeys) and Fix, with the prompt folded in<details>. A break that only happens together is shown under "Held" as "Breaks together". All of this text is escaped: it can't @mention anyone, render HTML, break the table or close the fence. Query values are redacted across the whole comment.How it was verified
prescale ciagainst the example shop, with local stand-ins for the dashboard upload and GitHub's comment API.SHOP_PASSWORDappears 0 times.investigateprints the prompt as above.diagnose=True@, HTML, backticks, a```in evidence)--pathServerheaderruff check cli/src cli/tests: clean ·pytest cli/tests -q: 361 passed (15 new).Risk
Tier: risky.
Public surface:
fix_prompt(additive;schema_versionstays 1)prescale cijourney runs now diagnoseDiagnosis in CI costs:
max-rps), with writes for journeys that change dataThe Action README says so, and it's under the same host and write rules.
Rollback: revert. Nothing stored changes meaning.
Fresh-context review: no blockers. Three should-fixes, all done:
--pathand--urls, and "When" read "latency at ~30".Also done from the review:
Serverheader is cleanedNotes for review
investigateis still URL-only. Adding journey inputs to MCP tools is a one-way door that belongs with Journeys 3 (the MCP mapping driver).Generated by Claude Code