Toy WfMS flow controllers actually produce a subgraph - #326
Merged
Merged
Conversation
Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Liam Huber <liamhuber@greyhavensolutions.com>
And run the workflows by actually leveraging those edges in order to keep the claims and the results in lock-step Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Liam Huber <liamhuber@greyhavensolutions.com>
To reflect new for-loop behaviour in the toy WfMS Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Liam Huber <liamhuber@greyhavensolutions.com>
Down into the prospective submodule. It's not important enough or independent enough to be in the top-level module. It generates prospective recipes, so let's move it here. Signed-off-by: Liam Huber <liamhuber@greyhavensolutions.com>
Signed-off-by: Liam Huber <liamhuber@greyhavensolutions.com>
To reflect location of tested module Signed-off-by: Liam Huber <liamhuber@greyhavensolutions.com>
The suite was a stop-gap from when the flow controllers completely failed to produce edges. I don't mind the test, but it can be a lot simpler. Signed-off-by: Liam Huber <liamhuber@greyhavensolutions.com>
Signed-off-by: Liam Huber <liamhuber@greyhavensolutions.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
========================================
Coverage 99.95% 99.95%
========================================
Files 52 53 +1
Lines 4016 4125 +109
========================================
+ Hits 4014 4123 +109
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
The new drawing functionality makes it really easy to quickly validate that the internal structure is indeed getting correctly generated import flowrep as fr
@fr.workflow
def do_while(x0=1, limit=10, step=2):
x = x0
while fr.std.lt(x, limit):
x = fr.std.add(x, step)
return x
fr.tools.run_recipe(do_while.flowrep_recipe).draw(depth=2)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #325
Pulls down a simplified flowrep-version of
pyiron_workflow.transformersand the flow controller execution logic. The transformers are lightweight and I'm happy to have them here; the wfms module changes are heavier weight, but IMO the cost is worth it for the toy WfMS to actually produce subgraphs correctly. This resolves the trouble with the drawn for-loop retrospective data in the user guide.flowrep.schemas.Transform1toNand.TransformNto1got added to the API, but otherwise this is patch-level under-the-hood stuff where the WfMS actually follows through on stuff it should have been doing, but has no impact on the terminal results of any of the workflows.