Allow compiling inside modules that are still importing - #323
Merged
Merged
Conversation
By modifying how `object_scope` resolves attributes to object. Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Liam Huber <liamhuber@greyhavensolutions.com>
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 44 44
Lines 3586 3590 +4
=======================================
+ Hits 3584 3588 +4
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By modifying how
object_scoperesolves attributes to object.Ran across the need for this in order to get the compatibility
@as_macro_nodein pyiron/pyiron_workflow#931 to fail early (at the time of parsing the decorated function, instead of at calling it).This is safely a patch change.