Skip to content

[pre-commit.ci] pre-commit autoupdate - #750

Merged
github-actions[bot] merged 3 commits into
mainfrom
pre-commit-ci-update-config
Sep 29, 2026
Merged

github-actions[bot] merged 3 commits into
mainfrom
pre-commit-ci-update-config

Conversation

@pre-commit-ci

@pre-commit-ci pre-commit-ci Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.16.8 → v0.16.9](astral-sh/ruff-pre-commit@v0.16.8...v0.16.9)
@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: d5a79ba7-919b-49c5-9bdc-eeb085eeac45

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jan-janssen

Copy link
Copy Markdown
Member

@copilot Can you fix the issue with the failing CI? It could be related to a change in phonopy, where you have to add the lang="C" parameter to the phonopy interface. At the same time this change required the minimal phonopy version to be 4.0.0 as this parameter was only introduced in phonopy 4.0.0

Copilot AI commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

@copilot Can you fix the issue with the failing CI? It could be related to a change in phonopy, where you have to add the lang="C" parameter to the phonopy interface. At the same time this change re...

Fixed in e0641e6. I updated the phonopy helper to construct Phonopy(..., lang="C") and raised the legacy CI pin in .ci_support/environment-old.yml to phonopy =4.0.0, which is the minimum version that supports that argument.

@jan-janssen

Copy link
Copy Markdown
Member

@copilot Fix the environment-old.yml conda environment to represent the lowest version of the given packages which are still compatible to each other. Note that is was necessary to update the lowest bound for phonopy to 4.0.0 so this requires other versions to be updated as well.

@codecov

codecov Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.77%. Comparing base (ccfc830) to head (96b34ec).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #750   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files          45       45           
  Lines        2651     2651           
=======================================
  Hits         2433     2433           
  Misses        218      218           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

@copilot Fix the environment-old.yml conda environment to represent the lowest version of the given packages which are still compatible to each other. Note that is was necessary to update the lowest ...

Fixed in 2ae0e1b. I updated .ci_support/environment-old.yml so the old environment remains a lowest compatible set with phonopy =4.0.0 by raising spglib to 2.5.0 while keeping the required scipy =1.11.3; I also verified the file solves with a conda dry run.

@jan-janssen
jan-janssen force-pushed the pre-commit-ci-update-config branch from 2ae0e1b to 99c70a6 Compare September 28, 2026 21:50
@github-actions
github-actions Bot merged commit 337bcc0 into main Sep 29, 2026
49 of 53 checks passed
@github-actions
github-actions Bot deleted the pre-commit-ci-update-config branch September 29, 2026 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants