Skip to content

Cleanup and write tests for clifford.cga - #183

Merged
eric-wieser merged 3 commits into
pygae:masterfrom
eric-wieser:cga-tidy
Oct 28, 2019
Merged

Cleanup and write tests for clifford.cga#183
eric-wieser merged 3 commits into
pygae:masterfrom
eric-wieser:cga-tidy

Conversation

@eric-wieser

@eric-wieser eric-wieser commented Oct 28, 2019

Copy link
Copy Markdown
Member

@eric-wieser eric-wieser added Maintenance Code cleanup without behavior changes testing component: cga Relating to `clifford.cga` labels Oct 28, 2019
@codecov

codecov Bot commented Oct 28, 2019

Copy link
Copy Markdown

Codecov Report

Merging #183 into master will increase coverage by 2.82%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #183      +/-   ##
========================================
+ Coverage   52.17%    55%   +2.82%     
========================================
  Files          41     42       +1     
  Lines        6355   6419      +64     
  Branches      987    989       +2     
========================================
+ Hits         3316   3531     +215     
+ Misses       2913   2743     -170     
- Partials      126    145      +19
Impacted Files Coverage Δ
clifford/cga.py 84.57% <100%> (+84.57%) ⬆️
clifford/test/test_cga.py 100% <100%> (ø)
clifford/tools/g3c/object_clustering.py 64.28% <0%> (-4.09%) ⬇️
clifford/test/test_g3c_tools.py 77.52% <0%> (-0.24%) ⬇️
clifford/_multivector.py 61.12% <0%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6403dd5...aee1302. Read the comment docs.

@eric-wieser

Copy link
Copy Markdown
Member Author

Travis passes, coverage increased, and there are open issues for all the xfailing tests. If the tests seem like nonsense, we can fix them in a follow-up / discuss in the open bugs

@eric-wieser
eric-wieser merged commit 899cd56 into pygae:master Oct 28, 2019
@eric-wieser
eric-wieser deleted the cga-tidy branch October 29, 2019 10:41
@arsenovic

Copy link
Copy Markdown
Member

nice job on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: cga Relating to `clifford.cga` Maintenance Code cleanup without behavior changes testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants