Skip to content

Doc: fix referencing in spherical submod#138

Merged
ahms5 merged 2 commits into
developfrom
doc/fix_referencinh
Jun 2, 2025
Merged

Doc: fix referencing in spherical submod#138
ahms5 merged 2 commits into
developfrom
doc/fix_referencinh

Conversation

@ahms5

@ahms5 ahms5 commented Jun 1, 2025

Copy link
Copy Markdown
Member

Which issue(s) are closed by this pull request?

contribues to fix all warnings during documentation build

Changes proposed in this pull request:

@ahms5 ahms5 added this to the v1.0.0 milestone Jun 1, 2025
@ahms5 ahms5 added the documentation Improvements or additions to documentation label Jun 1, 2025
@ahms5 ahms5 moved this from Backlog to Require review in Weekly Planning Jun 1, 2025
@ahms5 ahms5 requested a review from Copilot June 1, 2025 15:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes documentation warnings in the spherical module by updating reference citations in the docstrings.

  • Updated the reference section in spherical_harmonic_basis_gradient to include an additional reference.
  • Reorganized the references in spherical_harmonic_basis_gradient_real to improve clarity during documentation build.

Comment thread spharpy/spherical.py
Comment thread spharpy/spherical.py

@f-brinkmann f-brinkmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@github-project-automation github-project-automation Bot moved this from Require review to Reviewer Approved in Weekly Planning Jun 2, 2025

@hoyer-a hoyer-a left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, just one question.

Comment thread spharpy/spherical.py Outdated
derived in [#]_ and [#]_.


References

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also move the references to the end of the function docstring?

@ahms5 ahms5 requested a review from hoyer-a June 2, 2025 14:56
@ahms5 ahms5 merged commit ac67925 into develop Jun 2, 2025
10 of 11 checks passed
@github-project-automation github-project-automation Bot moved this from Reviewer Approved to Done in Weekly Planning Jun 2, 2025
@ahms5 ahms5 deleted the doc/fix_referencinh branch June 2, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants