End the queue producer span when a send rejects - #203
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
📝 WalkthroughWalkthroughQueue 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instrumentQueueSendandinstrumentQueueSendBatchinpackages/otel-cf-workers/src/instrumentation/queue.tscalledspan.end()only after the wrapped call resolved, with nothing wrapping it. So a rejectedqueue.send()orqueue.sendBatch()leaves its span unended and therefore never exported: the send disappears from the trace and the failure leaves no record, which is exactly when you would want the span. The queue consumer handler further up the same file already guards its own path, and the other bindings do too, so the producer side was the odd one out.Both now record the exception, set
ERROR, and end the span in afinally, rethrowing the original error untouched. This is the same fix as #201 for Analytics Engine, found by sweeping the instrumentation directory for files whosespan.end()count exceeded theirfinallycount.There was no test file for the queue bindings, so I added one covering a successful send plus both rejection paths. The two rejection tests fail on current main with
expected [] to have a length of 1, which is the span that never arrives. Ran the repo preflight andpnpm run check, both green. Patch changeset for@pydantic/otel-cf-workersincluded.quick disclosure: built with Claude Code's help and I went through the diff myself before opening. Freshman still learning the Workers side, so tell me if the producer span should behave differently on failure :)