Conversation
virtuald
force-pushed
the
test-harness-phase-one
branch
from
September 25, 2026 04:58
863af32 to
807e7e4
Compare
Correct only the two canonical stderr expectations. Commit e0aa238 (Resolve Inheritance Sort Issue, pybind#238) intentionally replaced alphabetical inspect.getmembers() module traversal with definition/pybind11 registration order, but left these error files from 84fa6d7 unchanged. The investigation reproduced the old bytes by restoring alphabetical module traversal in a disposable process; current diagnostics differ only in their ordering. Exact 1-based old-line sequences, including unchanged tails: v2.9: 4,5,2,3,7,6,8,1,13,11,9,12,10,14,15,16,17,18,19,20,21 v3.0: 2,1,7,5,3,6,4,8,9,10,11,12,13,14,15 This follows eigen -> enum -> aliases -> flawed_bindings registration: dense_matrix_r before dense_matrix_c, four_row before four_col, and get_unbound_type, accept_unbound_type, accept_unbound_enum, accept_unbound_type_defaulted, accept_unbound_enum_defaulted. The v3.0 fixture has no Eigen dimension errors, as before. Preserve every line byte and multiplicity, both eight-line warning and termination tails, and the v2.13 -> v2.12 -> v2.11 -> v2.9 alias chain. No production, harness normalization, stub, or native fixture changes. Verification: existing focused demo_errors tests fail before and pass after in py313-pb29-naa and py313-pb30-naa. Full unfiltered serial tox passes all 13 environments, each with 97 self-tests and 2 native tests (99 passed; 1287 total). Checks preserve reference trees and index. Two-file pre-commit hooks and git diff --check pass. No snapshot-update flags or remote CI actions; remote CI remains separately unverified.
virtuald
force-pushed
the
test-harness-phase-one
branch
from
September 25, 2026 16:37
e8fbf84 to
4c84bad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... I've barely reviewed this, so I don't expect anyone else will either.
Astra wants to implement this in four phases, so I'm going to wait until the end. Just pushing this up for CI purposes.