update for 2.1

[protocol-1903]

• Updated to Factorio 2.1
• Removed RECIPE.change_category, added add_category, remove_category, replace_category, has_category, and has_categories
• Updated annotations for emmylua integration
• Updated py.farm_speed and py.farm_speed_derived to use 0-indexed module slots with a building at native -100% speed
• Updated certain tests for new prototype properties
• Updated global checker
• Updated py.pipe_pictures to load graphics definitions directly from base instead of inferring them, allowing more to be used
• Fixed a potential crash when no tools are defined

[AverageCoder777]

return desired_speed / (num_slots / module_bonus) / module_bonus in lib/data_stages.lua:154 are incorrect.

For yotoi: farm_speed(33, 1.3, 0,3) equals 1.3 / (33/0.3)/0.3 = 1.3/110/0.3 = 0.039 base speed
0.039 * 9.9 from modules = 0.3861 final speed instead 1.3
I don't know why there's such a complicated formula here when you can just use desired speed / (num_slots * module_bonus) and that's it.
With this formula we get: 1.3/9.9 = 0.13(13), 0.13(13)*9.9 = 1.3
A very simple reversal of the original calculation formula

Default formula

Modified formula

This problem didn't exist in the master branch for version 2.0. I noticed this glitch at 2.1 because my aloe production dropped by a factor of 4, and I started running out of it for cellulose.

[protocol-1903]

return desired_speed / (num_slots / module_bonus) / module_bonus in lib/data_stages.lua:154 are incorrect.

For yotoi: farm_speed(33, 1.3, 0,3) equals 1.3 / (33/0.3)/0.3 = 1.3/110/0.3 = 0.039 base speed
0.039 * 9.9 from modules = 0.3861 final speed instead 1.3
I don't know why there's such a complicated formula here when you can just use desired speed / (num_slots * module_bonus) and that's it.
With this formula we get: 1.3/9.9 = 0.13(13), 0.13(13)*9.9 = 1.3
A very simple reversal of the original calculation formula

Default formula

Modified formula

This problem didn't exist in the master branch for version 2.0. I noticed this glitch at 2.1 because my aloe production dropped by a factor of 4, and I started running out of it for cellulose.

Gonna hold off on that for now, I'm looking into a minor rebalance of AL module scaling anyway so numbers and things are subject to change