142 incorrect line numbers in getlogicallines - #143
Merged
da4089 merged 2 commits intoAug 12, 2026
Conversation
In some cases, the vobject text supplied does not have a line terminator on the final line of the string/file. This was handled using the regex "$" syntax, but that meant every line was reporting an extra line number consumed, because "$" matches either the end of the string, or immediately before a final CR/LF. So, logical lines still match either a CRLF, CR, LF, or "$", but when removing folded lines, there's now an explicit check for a training terminator, and one is added if it's missing. That ensures every line increments the counter by at least one, and the returned line numbers are now correct for both folded and unfolded lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regex used to identify the end of a logical line attempted to deal with a missing line terminator, but in doing so, caused an error in the reported line numbers for parsing errors.
This patch fixes that.