Skip to content

LukeMS's port of the PyGame time API to sdl2#172

Open
knghtbrd wants to merge 1 commit into
py-sdl:masterfrom
knghtbrd:master
Open

LukeMS's port of the PyGame time API to sdl2#172
knghtbrd wants to merge 1 commit into
py-sdl:masterfrom
knghtbrd:master

Conversation

@knghtbrd

@knghtbrd knghtbrd commented Nov 11, 2020

Copy link
Copy Markdown

@LukeMS has this added to his personal sdl2 repo on GitHub, but hasn't
offered the patch upstream. Enough people seem to want it that I've
decided ti offer it as a PR. I didn't take time to write unit tests for
it, sorry. Closes #168.

I've stopped using this code, instead preferring to let my update loop run as often as it does and keep track of elapsed ticks. When enough have passed for something to happen, I do it. But this API provides the simplicity of the PyGame API in this respect because it duplicates that API pretty exactly.

LukeMS has this added to his personal sdl2 repo on GitHub, but hasn't
offered the patch upstream. Enough people seem to want it that I've
decided ti offer it as a PR. I didn't take time to write unit tests for
it, sorry. Closes py-sdl#168.
@a-hurst

a-hurst commented Dec 16, 2020

Copy link
Copy Markdown
Member

@iKarith Thanks so much for the PR! Sorry for not getting around to this sooner, I've been super-busy with various time-sensitive academic projects. I'll try to review this properly this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing module sdl2.ext.time

2 participants