Repository navigation
DEV: Add ci-success step in github-ci workflow - #279
Merged
Merged
Conversation
oscrypto 1.3.0 (latest on PyPI) fails to parse OpenSSL versions with a two-digit patch number (e.g. 3.0.13), raising LibraryNotFoundError when endesive.pdf is imported. Install the fixed upstream commit in CI and import endesive.pdf lazily so only check-sign is affected for users. endesive 3.x changed pdf.verify() to return Result objects, which breaks check-sign. Pin endesive<3 until we migrate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since pypdf 6.16.2, extract_text() puts the two halves of a booklet page on separate lines instead of joining them with a space. The test is about page order, so compare the words per output page instead of the exact text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes CI and adds a single ci-success step to the github-ci workflow, so that we can enforce that this has to pass before a merge.