Repository navigation
table: raise a clear error when text_align has too few values - #2056
Open
RavSinghChandan wants to merge 1 commit into
Open
RavSinghChandan wants to merge 1 commit into
RavSinghChandan wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FPDF.table()accepts a tuple fortext_align, one value per column. With fewer values than columns, such astext_align=("CENTER", "RIGHT")for a 4-column table, rendering failed with a bareIndexError: tuple index out of range.It now raises
ValueError: Invalid .text_align specified: missing alignment for table() column 3 on row 1, the same kind of messagecol_widthsalready gives when it is too short. Tables with enough values behave as before. Added a test for the message.