Repository navigation
write_html: treat all HTML void elements as having no end tag - #2053
Merged
Merged
Conversation
andersonhc
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write_html()logs "Missing HTML end tag for " and "Unexpected HTML end tag , start tag was " for a normal HTML email head, because<meta>is not inHTML_UNCLOSED_TAGS. The same happens for the other void elements, which never have an end tag in HTML:<link>,<col>,<wbr>,<input>,<base>,<area>,<embed>,<source>and<track>. Only<br>,<hr>and<img>were listed.All HTML void elements are now in
HTML_UNCLOSED_TAGS, so they leave the tag stack like<br>does, and valid HTML no longer produces these warnings. Real mismatches are still reported (test_warn_on_tags_not_matchingis unchanged). Added a test with a typical email<head>, a<colgroup>,<wbr>and<input>.