Repository navigation
write_html: do not render the content of <style> and <script>, like b… - #2044
Merged
andersonhc merged 2 commits intoOct 21, 2026
Merged
Conversation
andersonhc
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write_html()wrote the content of<style>and<script>elements into the PDF as text. An HTML page or email with a<style>block in its head came out with the CSS printed at the top of the document, for examplep { color: red; }followed by the actual text. Browsers never display these elements.The parser now skips their content, the same way it already skips
<title>text unlessrender_title_tag=True. Inlinestyleattributes are not affected. Added a test comparing documents with<style>/<script>blocks against the same document without them.