Repository navigation
write_html: let table cells without a width share the rest, like brow… - #2035
Merged
andersonhc merged 3 commits intoOct 22, 2026
Merged
Conversation
Collaborator
|
After a quick look, I have two questions worth investigating:
|
Author
|
Both were real. Colspan was recorded per cell instead of per column. Cellspacing wasn't subtracted before sharing the width. |
andersonhc
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A table whose first row gives a
widthto only some of its cells, such as<td width="50%">a</td><td>b</td>, madewrite_html()raiseValueError: Invalid .col_widths specified: missing width for table() column 2. Browsers lay the cells with a width out first and let the others share the remaining space.write_html()now remembers the width of every cell of the first row, and when some have none, the others share what is left of the table width (the average width if nothing is left). Rows where every cell has a width are unchanged. Added tests comparing against the equivalent fully specified widths, for percentages and an absolute width.