Skip to content

fix: remove zero-fill in singlediode DC model to preserve NaNs (Close… #2763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mohamedhassan268 wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −3
Open

fix: remove zero-fill in singlediode DC model to preserve NaNs (Close… #2763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions pvlib/modelchain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,9 +665,6 @@ def _make_diode_params(photocurrent, saturation_current,
self.results.dc,
unwrap=False
)
self.results.dc = tuple(dc.fillna(0) for dc in self.results.dc)
# If the system has one Array, unwrap the single return value
# to preserve the original behavior of ModelChain
Comment on lines -669 to -670
Copy link
Copy Markdown
Member

@cwhanse cwhanse May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo this delete - the comment is about the following if statement.

if self.system.num_arrays == 1:
self.results.diode_params = self.results.diode_params[0]
self.results.dc = self.results.dc[0]
Expand Down
Loading