Use Litmus public fallback for fork PR CI#1481
Open
alex-harvey-z3q wants to merge 1 commit into
Open
Conversation
alex-harvey-z3q
requested review from
a team,
alexjfisher,
b4ldr,
bastelfreak,
ekohl,
seanmil and
smortex
as code owners
July 20, 2026 10:17
alex-harvey-z3q
force-pushed
the
codex/fix-pr-ci-nightly
branch
from
July 20, 2026 10:26
39eff3e to
743d5ff
Compare
alex-harvey-z3q
changed the title
alex-harvey-z3q
force-pushed
the
codex/fix-pr-ci-nightly
branch
2 times, most recently
from
July 20, 2026 10:48
e150da2 to
0343ab3
Compare
alex-harvey-z3q
changed the title
Require puppet_litmus ~> 2.5 for system tests so matrix_from_metadata_v3 accepts --nightly and falls back to public Puppet collections when PUPPET_FORGE_TOKEN is unavailable. Keep CI workflow nightly flags unchanged so trusted runs still exercise nightly Puppetcore packages. Closes puppetlabs#1480
alex-harvey-z3q
force-pushed
the
codex/fix-pr-ci-nightly
branch
from
July 21, 2026 00:52
0343ab3 to
a2d4719
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use
puppet_litmus ~> 2.5for system tests.The CI workflow keeps passing
flags: "--nightly"to the shared acceptance workflow. This preserves the intended nightly Puppetcore coverage for trusted CI runs.The failing fork PR path does not receive repository secrets, so
PUPPET_FORGE_TOKENis unavailable. With the previous Gemfile logic, that selectedpuppet_litmus ~> 1.0. That oldermatrix_from_metadata_v3path either rejects--nightlyor still generates nightly Puppet collections by default, which breaks unauthenticated fork PR acceptance setup/runs.Litmus 2.5+ has the behavior this workflow needs:
--nightlyPUPPET_FORGE_TOKENis present, it can use nightly Puppetcore collectionsPUPPET_FORGE_TOKENis absent, it falls back to the public Puppet collection instead of trying to use private nightly packagesAssumption / Tradeoff
This PR assumes the maintained path for unauthenticated fork PRs is to use current Litmus public fallback behavior rather than keeping fork PRs pinned to Litmus 1.x.
That preserves the existing workflow intent more closely than conditionally removing
--nightlyfrom fork PRs: trusted runs can still request nightly Puppetcore packages, while fork PRs can complete with public packages when secrets are unavailable.Verification
ruby -c Gemfile.github/workflows/ci.ymlwith Ruby YAMLgit diff --checkCloses #1480