[rwaffen]

Summary

To get an overview of all my postgress installations I want to be able to filter by version.

Checklist

• 🟢 Spec tests.
• 🟢 Acceptance tests.
• Manually verified. (For example puppet apply)

[SimonHoenscheid]

Code LGTM, I only ask myself what that means for multiple instances. I have no answer for that so far.

[rwaffen]

acceptance seems broken :(

bundle exec matrix_from_metadata_v3 --nightly --platform-exclude centos-7 --platform-exclude oraclelinux-7 --platform-exclude scientific-7 --collection-platform-exclude 9:redhat-7 --collection-platform-exclude 9:debian-10 --collection-platform-exclude 9:ubuntu-18.04 --collection-platform-exclude 9:ubuntu-20.04

Error: invalid option: --nightly

[jst-cyr]

@rwaffen : Acceptance tests don't run correctly on Forked PRs. We'll need to spawn a branch to run the acceptance tests and get those results.

[jst-cyr]

Running CI tests for this PR here: #1720

[jst-cyr]

Acceptance Test Results: https://github.com/puppetlabs/puppetlabs-postgresql/actions/runs/38943530437?pr=1720

Full green across the board! PR looks good from testing perspective, needs engineering review.

[deric]

This has been already proposed e.g. in #1609. It's hard to make this work universally, it won't work if someone is running multiple PostgreSQL clusters on a single node.

[rwaffen]

oh we had this already?

but like @bastelfreak said in #1609

I think in this case it's fine to only have a 80% solution. If it works for the common setups and the edge cases are documented, that is fine in my opinion.

#1609 (comment)