Repository navigation
Conversation
jst-cyr
requested review from
a team,
bastelfreak,
ekohl and
smortex
as code owners
October 21, 2026 20:25
Contributor
|
Hi @jst-cyr , Can you please update the PR? |
apache::fastcgi::server has included apache::mod::fastcgi since that class was removed in 84940ea (v10.0.0, 2023), so every invocation of the define has unconditionally failed catalog compilation since then. The define also had two independent latent bugs (an unset $socket variable and invalid string concatenation in server.epp) that would have surfaced if the missing class were ever restored. Since mod_fastcgi is dead upstream and unavailable on any currently supported OS, and the define has never worked in any released version since v10.0.0, remove it outright along with its leftover erb/epp templates and REFERENCE.md entry rather than resurrect unmanageable functionality. Fixes #2640 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
jst-cyr
force-pushed
the
MODULES-12060-fix-fastcgi-server
branch
from
October 24, 2026 02:20
f1ab485 to
12169e9
Compare
Member
Author
|
@skyamgarp : I've rebased with latest which will trigger the tests again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apache::fastcgi::serverhas unconditionally failed catalog compilation in every released version since v10.0.0 (2023), because it doesinclude apache::mod::fastcgi— a class that was deleted in Drop mod_fastcgi support #2267 ("Drop mod_fastcgi support") when mod_fastcgi was dropped as dead upstream software unavailable on any currently supported OS.$socketvariable that's only assigned under a conditional, and invalid+string concatenation intemplates/fastcgi/server.epp(Puppet's+doesn't concatenate strings).apache::fastcgi::server, its leftoverserver.epp/server.erbtemplates, and theREFERENCE.mdentry (regenerated viarake strings:generate:reference).Closes #2640
Test plan
bundle exec rake validatepassesbundle exec rake rubocoppasses