fix(ci): migrate loom-testing to rand 0.10 API — unblocks all CI#275
Merged
Conversation
rand floated to 0.10 (Cargo.lock is gitignored, #142), which renamed thread_rng() -> rng(), Rng::gen_range() -> RngExt::random_range(), and deprecated the RngCore trait in favour of Rng. loom-testing's EMI module still used the 0.8 API, so CI failed to compile it and all loom CI (including v1.2.0 release) was blocked. Update the code to the rand 0.10 API to match the already-bumped `rand = "0.10"` spec in loom-testing/Cargo.toml (#265). Refs: #142 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks all loom CI (currently fully red).
loom-testingfailed to compile:cannot find trait RngCore/cannot find function thread_rng in crate rand.Root cause: Dependabot #265 bumped
loom-testing/Cargo.tomltorand = "0.10"but never updated the source, so the spec and code were out of sync (and with Cargo.lock gitignored, CI floats to 0.10 — #142). Fix = match the code to the already-declared 0.10 API (8 lines,loom-testing/src/emi/mod.rs):rand::thread_rng()→rand::rng()Rng::gen_range()→random_range()Box<dyn RngCore>→Box<dyn Rng>(RngCore deprecated in rand_core 0.10)Verified in an isolated target:
cargo build --release --workspaceFinished; clippy clean; fmt clean. Refs #142.Durable follow-up: commit
Cargo.lock(#142) — this is the 3rd recurrence of a gitignored-lockfile dep-float breaking CI with no code change (wasmtime 45, criterion, now rand). Recommend prioritizing before more releases.