fix(drv): gate the PROVIDERS enumeration against reality - #314
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
build-gustos-components.sh enumerates five providers by hand. Unlike the other
enumerated lists found this month, that one is CORRECT to enumerate: it defines
the published v0.4.0 composition, and a newly added provider must not silently
join the fused composite just by existing. Glob discovery would be the wrong
fix here.
What was missing is the check that the deliberate list still matches reality.
An enumeration nobody verifies is exactly how the Lean target list,
check-providers.sh, and build-cross-arch.sh each came to exclude the newest
thing without saying so.
So: enumerated on purpose, and gated. If a *-provider directory exists that is
not listed, the script fails and names it, and the fix is a deliberate decision
(add it to PROVIDERS and build-fused-gustos.sh, or record why it is excluded)
rather than a silent skip.
Kill-criterion, both directions verified:
real tree (5 listed, 5 present) -> exit 0, no drift reported
mkdir can-provider (5 listed, 6 present) -> exit 2:
present but unlisted: can-provider
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011QG86sovTbfnPNY9SfhSmo
avrabe
force-pushed
the
fix/provider-list-drift
branch
from
August 28, 2026 02:30
8e6eff4 to
e6f3464
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the enumerated-list sweep started in #313.
build-gustos-components.shenumerates five providers by hand. Unlike the otherlists found this month, that one is correct to enumerate — it defines the
published v0.4.0 composition, and a newly added provider must not silently join
the fused composite just by existing. Glob discovery would be the wrong fix.
What was missing is the check that the deliberate list still matches reality. An
enumeration nobody verifies is exactly how the Lean target list,
check-providers.sh, andbuild-cross-arch.sheach came to exclude the newestthing without saying so.
Now: enumerated on purpose, and gated. A
*-providerdirectory that is notlisted fails the script and is named. The fix is then a deliberate decision — add
it to
PROVIDERSandbuild-fused-gustos.sh, or record why it is excluded —rather than a silent skip.
Kill-criterion (both directions verified)
mkdir can-provider(5 listed, 6 present)Sweep status
//proofs/lean:allcheck-providers.shbuild-cross-arch.shcheck-driver-components.pybuild-gustos-components.sh🤖 Generated with Claude Code
https://claude.ai/code/session_011QG86sovTbfnPNY9SfhSmo