Skip to content

fix: routeの定義を共通関数化した#1726

Merged
laminne merged 3 commits into
mainfrom
refactor/1613-router-helper
Jul 7, 2026
Merged

fix: routeの定義を共通関数化した#1726
laminne merged 3 commits into
mainfrom
refactor/1613-router-helper

Conversation

@laminne

@laminne laminne commented Jul 7, 2026

Copy link
Copy Markdown
Member

close #1613

What does this PR do?

  • routeの定義で作るオブジェクトの共通部分をhelperに分離
  • helperを使って全定義を置き換え

Additional information

  • 手元でAPI定義の出力に差分が無いことをチェック済みです

@laminne laminne self-assigned this Jul 7, 2026
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.33%. Comparing base (c6281af) to head (b37688a).

Files with missing lines Patch % Lines
pkg/internal/router/helper.ts 0.00% 16 Missing ⚠️
pkg/accounts/router.ts 0.00% 12 Missing ⚠️
pkg/timeline/router.ts 0.00% 4 Missing ⚠️
pkg/notes/router.ts 0.00% 3 Missing ⚠️
pkg/drive/router.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1726      +/-   ##
==========================================
- Coverage   45.53%   45.33%   -0.21%     
==========================================
  Files         159      160       +1     
  Lines        5749     5775      +26     
  Branches      927      932       +5     
==========================================
  Hits         2618     2618              
- Misses       3131     3157      +26     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@laminne laminne force-pushed the refactor/1613-router-helper branch from 3c0befd to b37688a Compare July 7, 2026 13:03
@laminne laminne marked this pull request as ready for review July 7, 2026 13:08
@laminne laminne enabled auto-merge July 7, 2026 13:08
@laminne laminne requested a review from MikuroXina July 7, 2026 13:08
@laminne laminne added this pull request to the merge queue Jul 7, 2026
Merged via the queue into main with commit b3c486c Jul 7, 2026
3 of 5 checks passed
@laminne laminne deleted the refactor/1613-router-helper branch July 7, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: routeのスキーマ定義用のファクトリメソッドを作る

2 participants