refactor: AccountモジュールのServiceをCat.doTを使って書き直した#1725
Open
laminne wants to merge 4 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1725 +/- ##
==========================================
- Coverage 45.53% 45.23% -0.30%
==========================================
Files 159 159
Lines 5749 5597 -152
Branches 927 844 -83
==========================================
- Hits 2618 2532 -86
+ Misses 3131 3065 -66 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MikuroXina
requested changes
Jul 7, 2026
| }); | ||
|
|
||
| return Option.none(); | ||
| return Result.isErr(res) ? Option.some(res[1]) : Option.none(); |
Contributor
There was a problem hiding this comment.
この処理は Result.optionErr で書けます. unfollow.ts の方も同様です.
Suggested change
| return Result.isErr(res) ? Option.some(res[1]) : Option.none(); | |
| return Result.optionErr(res); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1712
What does this PR do?
Additional information