Skip to content

refactor: AccountモジュールのServiceをCat.doTを使って書き直した#1725

Open
laminne wants to merge 4 commits into
mainfrom
refactor/1712-account-cat-doT
Open

refactor: AccountモジュールのServiceをCat.doTを使って書き直した#1725
laminne wants to merge 4 commits into
mainfrom
refactor/1712-account-cat-doT

Conversation

@laminne

@laminne laminne commented Jul 7, 2026

Copy link
Copy Markdown
Member

close #1712

What does this PR do?

  • AccountモジュールのServiceをCat.doTを使って書き直しました

Additional information

  • メモ: RepositoryがOptionを返すせいで面倒になっている箇所があるので早めになおす

@laminne laminne requested a review from MikuroXina July 7, 2026 11:02
@laminne laminne self-assigned this Jul 7, 2026
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.10526% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.23%. Comparing base (c6281af) to head (f22c928).

Files with missing lines Patch % Lines
pkg/accounts/service/verifyToken.ts 58.82% 7 Missing ⚠️
pkg/accounts/service/silence.ts 87.50% 2 Missing ⚠️
pkg/accounts/service/authenticate.ts 87.50% 1 Missing ⚠️
pkg/accounts/service/edit.ts 96.96% 1 Missing ⚠️
pkg/accounts/service/register.ts 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1725      +/-   ##
==========================================
- Coverage   45.53%   45.23%   -0.30%     
==========================================
  Files         159      159              
  Lines        5749     5597     -152     
  Branches      927      844      -83     
==========================================
- Hits         2618     2532      -86     
+ Misses       3131     3065      -66     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@laminne laminne enabled auto-merge July 7, 2026 11:08
});

return Option.none();
return Result.isErr(res) ? Option.some(res[1]) : Option.none();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この処理は Result.optionErr で書けます. unfollow.ts の方も同様です.

Suggested change
return Result.isErr(res) ? Option.some(res[1]) : Option.none();
return Result.optionErr(res);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: Accountモジュールの処理をCat.doTを使って書き直す

2 participants