Conversation
`axi_to_apb` (#431) was added to Bender.yml and src_files.yml but not to the FuseSoC core file, so the new manifest consistency check fails. Add both the module and its testbench in the positions they occupy in Bender.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fuse_xsimCI job (FuseSoC + Vivado xsim) had been broken for a long time and was markedallow_failure, so xsim compatibility regressions went unnoticed. This PR fixes all the issues that made it fail and makes the job blocking again, restoring basic xsim test coverage.common_cellsandtech_cells_genericto revisions containing their own xsim/FuseSoC fixes.ifndef XILINX_SIMULATOR.axi.coreto align withBender.yml.axi.corein sync withBender.yml. Happy to revert it if not necessary or if it looks too cumbersome.common_cellsandtech_cells_generic.