Expose AxiLookBits in axi_burst_splitter to avoid logic explosion - #436
Open
briann-bui wants to merge 8 commits into
Open
Expose AxiLookBits in axi_burst_splitter to avoid logic explosion#436briann-bui wants to merge 8 commits into
briann-bui wants to merge 8 commits into
Conversation
imchenwu
requested changes
Jul 24, 2026
imchenwu
left a comment
imchenwu
left a comment
Collaborator
There was a problem hiding this comment.
Hi, thnaks for working on it :).
axi_burst_unwrapinstantiates its internal demux with the same hardcoded.AxiLookBits(IdWidth)and should also expose this parameter, otherwise it has the same issue.- When exposing the new parameter, please add a one-line comment explaining its usage and the implicit constraint (
AxiLookBits <= AxiIdWidth). You can simply point to the existing documentation indoc/axi_demux.md. - It would be good to add a parameter check in the end of
axi_burst_splitter_gran, e.g.
assume (AxiLookBits > 0 && AxiLookBits <= IdWidth) else
$fatal(1, "AxiLookBits (%0d) must be in ]0, IdWidth (%0d)]!", AxiLookBits, IdWidth);
also add the corresponding check in axi_to_axi_lite module.
Author
|
Hi @imchenwu, I've pushed a new commit to address all 3 of your requested changes. Could you please take another look when you have a moment? Thanks! |
imchenwu
requested changes
Jul 27, 2026
Author
|
@imchenwu, I have addressed all six review threads in commit
All conversations are resolved. Could you please review again when convenient? Thanks! |
Document INCR/FIXED/WRAP burst behavior in the module headers of axi_dw_converter, axi_dw_downsizer, and axi_dw_upsizer. Closes pulp-platform#429.
… interfaces. The original multi-dimensional interface module is not supported by many tools. Downstream users can still trivially write their own intf wrapper. Close pulp-platform#353.
…meter (pulp-platform#399) * src: axi_fifo_delay_dyn: Fix incorrect power-of-two check for `Depth` parameter The `axi_fifo_delay_dyn` module's parameter constraint checker incorrectly identified valid `Depth` values as not being a power of two. This commit corrects the logic to accurately verify that the `Depth` parameter is a power of two. * Update src/axi_fifo_delay_dyn.sv --------- Co-authored-by: Chen Wu <chenwu@iis.ee.ethz.ch>
* Bump to common_cells v2 * fix(cc): fix cc_ module parameter names for common_cells v2 Update parameter names to match the actual cc_ module API in v2-test: - cc_delta_counter: Width->WIDTH, StickyOverflow->STICKY_OVERFLOW - cc_stream_register: data_t->T - cc_fifo: FallThrough->FALL_THROUGH, Depth->DEPTH, data_t->dtype - cc_counter: Width->WIDTH Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * hw: Align mux and demux to common_cells v2 * hw: Align params name to common cells v2-test * hw: Remove test_i ports * hw: clean up dead test_i ports and use cc_pkg::lzc_mode_e enum for the cc_lzc MODE parameter. * fixed indentation * bumped common-cells v2.0.0-beta and tech-cells-generic 0.2.14 * bumped common2 fixes for synopsis tools * scripts: add target cc_no_deprecated * deps: Bump `common_cells` to `v2.0.0-beta.2` --------- Co-authored-by: Lorenzo Leone <lleone@iis.ee.ethz.ch> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Chen Wu <chenwu@iis.ee.ethz.ch> Co-authored-by: Niccolò Giuliani <niccolo.giuliani44@gmail.com>
imchenwu
force-pushed
the
fix/issue-341-axi-look-bits
branch
from
July 28, 2026 14:15
4089aac to
f7cae9d
Compare
imchenwu
approved these changes
Jul 28, 2026
Author
|
Hi @imchenwu, thanks for approving this PR. Is there anything else needed before it can be merged? |
Collaborator
|
Hi @briann-bui this PR changes the ports and downstream calling modules will require an update, so I would merge it in the next major release, together with the official release of common_cells v2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #341.
This PR exposes the
AxiLookBitsparameter inaxi_burst_splitter(and cascades it through toaxi_burst_splitter_granandaxi_to_axi_lite).Previously, the internal demux always instantiated with
AxiLookBitshardcoded to the fullIdWidth, which caused a massive logic explosion (counter array size of2**IdWidth) when dealing with large AXI IDs. By exposing this parameter (defaulting toIdWidthfor backwards compatibility), users can now override it appropriately.