Repository navigation
fix: write an analysis namespace another writer changed meanwhile - #86
Merged
Merged
Conversation
bfabio
force-pushed
the
analysis-namespace-timestamp
branch
from
September 4, 2026 14:17
80d9025 to
211016c
Compare
bfabio
force-pushed
the
analysis-namespace-timestamp
branch
from
September 4, 2026 14:20
211016c to
d3ebc5d
Compare
bfabio
force-pushed
the
analysis-namespace-timestamp
branch
from
September 4, 2026 14:30
d3ebc5d to
0c01f6e
Compare
The handler compared each incoming namespace with a copy of the row read before the merge and dropped the ones that looked unchanged. A namespace another writer changed between that read and the merge was never written, and the client got 200 with the other writer's value. The merge now compares against the row it updates: an unchanged namespace keeps its timestamp, a changed one is written.
bfabio
force-pushed
the
analysis-namespace-timestamp
branch
from
September 4, 2026 14:38
0c01f6e to
080b46f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The handler compared each incoming namespace with a copy of the row read before the merge and dropped the ones that looked unchanged. A namespace another writer changed between that read and the merge was never written, and the client got 200 with the other writer's value.
The merge now compares against the row it updates: an unchanged namespace keeps its timestamp, a changed one is written.