Address filed configuration and doc defects#231
Merged
Conversation
- configure.sh: drop 2>/dev/null in check_security so gh's error surfaces (matches check_secrets). - WORKFLOW.md D7.2/section 2: reword so it no longer claims reusable tasks *declare* permissions (they run under the caller's least-privilege grant). Closes #226 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates repository governance tooling and documentation around GitHub Actions permission semantics, and additionally introduces a set of migration planning documents under plans/.
Changes:
- Update
repo-config/configure.shsocheck_security()no longer suppressesgh apistderr for theautomated-security-fixescheck. - Reword
WORKFLOW.mdguidance to clarify that reusable workflows run under the caller-granted least-privilege permissions (and skipped jobs must still have valid declared permissions). - Add several new migration planning documents under
plans/(scope not currently reflected in the PR description).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| WORKFLOW.md | Clarifies permissions guidance for reusable workflows and skipped jobs. |
| repo-config/configure.sh | Removes stderr suppression so audit failures surface actionable gh diagnostics. |
| plans/INDEX.md | Adds an index for new migration plan documents. |
| plans/00-GOTCHA-BRIEFING.md | Adds shared briefing for branch-scoped CI/CD migration planning. |
| plans/nxwitness-migration-plan.md | Adds NxWitness migration/convergence plan document. |
| plans/homeassistant-purpleair-migration-plan.md | Adds HomeAssistant-PurpleAir migration/convergence plan document. |
| plans/esphome-nonroot-migration-plan.md | Adds ESPHome-NonRoot migration/convergence plan document. |
plans/ is local migration-planning scratch (created for review during the CI/CD work); it was swept in by git add -A and should not be tracked - it also contains non-ASCII punctuation that violates the repo doc rules. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #226
Validation: shellcheck + actionlint + markdownlint clean; line endings preserved.
🤖 Generated with Claude Code