Repository navigation
State pictures are asked for apart from coverage - #84
Merged
Merged
Conversation
with_coverage() added two kinds of generated test: one for each expectation no story reaches, which gives it a verdict, and one for each state of the state map no test passes through, which only gives the map a picture. Each arranges a start of its own, and on a system that is slow to set up the second kind was most of a run. - Acceptance::with_coverage() adds the Reaching tests only - Acceptance::with_state_pictures() adds the Visiting tests - expectation-run has both, and --no-state-pictures leaves the second out - expectation plan --state-pictures prints them; --coverage no longer does Callers of with_coverage() that want the state map's pictures now add with_state_pictures() after it. Refs #67 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of three PRs for #67 (the switch for state pictures). Sharing starts by continuing and by checkpoints follow.
with_coverage()added two kinds of generated test: "Reaching «…»", which gives an expectation a verdict, and "Visiting the state after «…»", which only gives the state map a picture. On a system that is slow to set up, the second kind was most of a run.What changes
Acceptance::with_coverage()adds the Reaching tests only.Acceptance::with_state_pictures()adds the Visiting tests. Call it afterwith_coverage().expectation-runstill has both by default;--no-state-picturesleaves the Visiting tests out.expectation plan --state-picturesprints them;--coveragealone no longer does.expectation docsis unchanged: it still lists both kinds.Behaviour change
Rust callers of
with_coverage()that want the state map's pictures must now add.with_state_pictures().A runner's results file holds its last run, so a quick run saved under the same
--runnername as a full run replaces the full run's Visiting results. The book says to give a quick run its own runner name.Tests
crates/harness/tests/state_pictures.rs: which tests each switch adds, that the order of the others is unchanged, and that every expectation's verdict is the same with and without pictures.crates/remote/tests/state_pictures.rs: the realexpectation-runbinary with and without--no-state-pictures.cargo test --workspaceandcargo clippy --workspace --all-targets -- -D warningspass locally.🤖 Generated with Claude Code