Repository navigation
Platform screenshots resolve to their own platform, and a failed setup is pictured - #81
Merged
Merged
Conversation
When the reset or an arrangement fails, the runner still asks for a screenshot and keeps it as the failed start's, in the docs directory or the store. The setup's error and the failed verdict stand whether or not there is a picture, the later steps are skipped as before, and nothing is asked of the driver when screenshots are off. A failed step's picture says so in the manual: "What it looked like when this failed." Closes #80 Co-Authored-By: Claude <noreply@anthropic.com>
expectation-run wrote a later platform's screenshots under its own tree (platforms/<name>/screenshots/) while its manual looked in the docs' shared screenshots/, under the same names the default platform uses. The manual showed "No screenshot of this step", or the default platform's picture. A later platform's per-test screenshots now go to screenshots/platforms/<name>/<test>/ in the shared docs directory, and its results name them so (RunOptions::screenshots_under, which Acceptance::run_options and expectation-run set). A per-test name outside that folder is from before this and is shown as a placeholder, in the platform's own manual and where the default manual borrows its results. Screenshots kept by content are unchanged. The kettle demo's SwiftUI and React Native screenshots move to their folders, and their results name them there. Closes #77 Co-Authored-By: Claude <noreply@anthropic.com>
A test took a random port from 5000 to 5999. fetch refuses 5060 and 5061, so on those the app never reached the runner and the test failed after 20 seconds. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each platform's results name its own screenshots (closes #77)
expectation-runwrote a later platform's screenshots underplatforms/<name>/screenshots/, while its manual looked in the docs' sharedscreenshots/under the same names the default platform uses. The manual showed a placeholder, or the default platform's picture.screenshots/platforms/<name>/<test>/in the shared docs directory, and its results name them so.RunOptions::screenshots_under,Acceptance::screenshots_under()andAcceptance::run_options(dir).expectation-run --docsuses them.screenshots/<test>/…is shown as a placeholder, in its own manual and where the default manual borrows its results.Picture a start that couldn't be set up (closes #80)
Tests
crates/remote/tests/platform_screenshots.rsruns the realexpectation-runbinary for two platforms with the same story and different images, regenerates withexpectation docs, and checks old-style names give a placeholder.crates/harness/tests/setup_failure.rscovers reset and arrangement failure with both destinations, a camera that also fails, and screenshots disabled.cargo test --workspaceandcargo clippy --workspace --all-targetspass locally.🤖 Generated with Claude Code