fix: serialize visible columns deterministically - #13
Open
MattKotsenas wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The order of
visible_columnsinpstoprcchanges nondeterministically between saves, producing no-op diffs that make the file noisy to track in version control.Summary
pstoprcPstopConfig::serialize()so config output is testable without touching%APPDATA%Runtime behavior is unchanged: column visibility remains set-based, and display order comes from the static column definitions. Existing config files are rewritten in canonical order on the next save.
Testing
visible_columns=16,0,9cargo test visible_columns_are_serialized_in_canonical_orderpasses