Skip to content

Restore JIT warmup calibration default - #245

Open
msimacek wants to merge 1 commit into
psf:mainfrom
msimacek:msimacek/graalpy
Open

msimacek wants to merge 1 commit into
psf:mainfrom
msimacek:msimacek/graalpy

Conversation

@msimacek

@msimacek msimacek commented Jul 2, 2026

Copy link
Copy Markdown

pyperf has the capability to do automatic warmup calibration for the interpreters that have a JIT. However, the CLI would set the default value of the --warmup option to 1, making it impossible to to use the warmup calibration from the CLI because you can't pass None to an int option.

The warmup argument used to have default None, but it was removed in #155 and then reintroduced again in #194 with default 1. This PR restores it back to None. This shouldn't change anything for CPython, since the None gets converted to 1 for interpreters without a JIT.

@vstinner

Copy link
Copy Markdown
Member

pyperf has the capability to do automatic warmup calibration for the interpreters that have a JIT.

In fact, it's an experimental feature. I'm not sure that it's a good idea to enable it by default.

Which Python implementation are you testing?

@msimacek

Copy link
Copy Markdown
Author

I'm testing GraalPy. Note that this has already been the default and we were using it, then it got removed. And it doesn't change anything for CPython. If you don't like having it as the default, then there should at least be some way to enable it from the CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants