Repository navigation
fix(release): wait for the npm tarball, not just its metadata - #84
Merged
Merged
Conversation
Run 37431530565 published 1.29.0 and saw complete metadata after ~45 s, but its single tarball download got a 404: npm served the tarball about five minutes after publish. The publish job failed, so no binaries or GitHub release were made until a manual rerun resumed it. downloadTarball now polls a 404 with the metadata wait's backoff and a unique query, sharing one DEFAULT_WAIT budget with the metadata wait so both stay inside the 20-minute job. Any other status fails at once, and the deadline still ends in 'never republish'. Deliberate break: treating every failed fetch as final turns tests/publish-npm-verify.test.ts from 31 pass to 29 pass / 2 fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mkczarkowski
added a commit
that referenced
this pull request
Oct 6, 2026
Takes master's 1.30.0, already on npm; the stale 1.29.1 bump from the prepare-version bot is dropped and the bot recomputes it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Mrk1nt2Ky21Thcv4PxrAzm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 1.29.0 release (run 37431530565) failed in
release / publishwithRegistry tarball unavailable, afternpm publishhad already succeeded. The metadata wait (#50, #69) polls with backoff, but the tarball download right after it made one attempt. npm completed 1.29.0's metadata ~45 s after publish, while the tarball 404'd for ~5 minutes (published 07:46:35, served 07:51:53). Binaries and the GitHub release were skipped until a manual rerun resumed (reason: resumed, no republish).downloadTarballnow polls: only a 404 means "not yet" (backoff 1 s → 15 s, unique?t=query like the metadata poll). Any other status fails at once.DEFAULT_WAITbudget (10 min) in bothverifyand the resume path, so the 20-minute job timeout still holds.None of the recent commits touched this path (#79 is test-only, #80 is PR-run cancellation); it's been a single fetch since #50.
Test plan
tests/publish-npm-verify.test.ts31 pass → 29 pass / 2 fail?t=query (200)bun testfull suite (3 failing Stop-hook tests are the known local bash 3.2 failures), typecheck, lint🤖 Generated with Claude Code