(CU-86bbujdhn) Quote the hook script path in .claude/settings.json - #351
Merged
Merged
Conversation
sh $CLAUDE_PROJECT_DIR/x.sh works until the path contains a space. The hooks reference requires the placeholder to be double-quoted in shell form. Aligns these repos with the form used everywhere else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${CLAUDE_PROJECT_DIR}placeholder in the.claude/settings.jsonhook commandsThese hooks already used shell form and work today, so this is hardening rather than a bug fix:
sh $CLAUDE_PROJECT_DIR/x.shbreaks the day the checkout path contains a space. The hooks reference is explicit — "In shell form, wrap each placeholder in double quotes."Companion to prowide/pw-swift-integrator#2019 and the other repos on this branch, which fixed the separate exec-form defect that broke hooks on native Windows. This change brings the last three repos to the same form, so every Prowide repo now writes hooks the same way.
No CHANGELOG entry: SCM/tooling configuration only.
Test plan