feat(skills): graft enforcement layer onto discipline skills#33
Merged
Conversation
Adapt the superpowers technique — a stated Iron Law, a Rationalizations table, and a Red Flags self-check — onto the five discipline skills (tdd-cycle, verify-change, csdd-quality-gate, pr-review, safe-refactor), preserving their existing csdd evidence discipline (CLI evidence steps, Completion Criteria, Verification Before Reporting). Also convert each skill's intro into the required `## Goal` section — the four shared skills were previously failing `csdd skill validate` for lack of it — and tighten each `description` front-matter to be trigger-only, not a workflow summary. Layer-2 templates are kept byte-identical to their layer-3 copies; csdd-quality-gate stays layer-3-only. Sync update_test.go's pinned verify-change description and add the four shipped discipline skills to TestShippedWorkflowSkillsValidate as a regression guard for their required headings. Spec: harden-discipline-skills (tasks 1-8) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adapts the
superpowersenforcement technique onto csdd's five discipline skills, while preserving their existing csdd evidence discipline. Each skill gains:## The Iron Law— one inviolable, imperative rule with explicit loophole-closers.## Rationalizations— an| Excuse | Reality |table that pre-empts the exact excuses an agent uses under pressure, ending in the verbatim "Violating the letter of the rule is violating its spirit."## Red Flags — STOP— thought-phrased self-checks that send the agent back to the workflow.It also tightens each
descriptionfront-matter to be trigger-only (not a workflow summary, which the superpowers method shows makes agents skip the body), and converts each skill's intro into the required## Goalsection.Spec
harden-discipline-skills(gitignored layer-3, dogfooded locally) — requirements → design → tasks all human-approved; tasks 1–8 complete.development_flow: unit(prose work; per-behavior "test" iscsdd skill validate+ byte-parity + subagent pressure test).What changed (committable)
internal/templater/templates/skills/{tdd-cycle,verify-change,pr-review,safe-refactor}/SKILL.md.tmpl— the layer-2 shipped baseline, kept byte-identical to the layer-3 copies.csdd-quality-gateis hardened too but is layer-3-only (gitignored), so it's not in this diff.internal/cli/update_test.go— sync the test fixture that pinned verify-change's old description (necessary because R4 rewrote it).internal/cli/cli_test.go— add the four shipped discipline skills toTestShippedWorkflowSkillsValidateas a regression guard.Notable findings
csdd skill validate(missing## Goal) before this PR — undetected because no test validated them. Fixed, and the new regression guard locks it in.development_flowfromspec.jsonwhen re-serializing (predates that field). Tracked separately as a follow-up issue.Verification
```
```
Risks
csdd init.🤖 Generated with Claude Code