upb: reject repeated message extensions in GetOrPromoteExtension - #29291
Open
paulocsanz wants to merge 1 commit into
Open
upb: reject repeated message extensions in GetOrPromoteExtension#29291paulocsanz wants to merge 1 commit into
paulocsanz wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
GetOrPromoteExtension stores a upb_Message* in the extension slot. Repeated extensions are consumed as upb_Array* (encoder, accessors), so promoting a repeated message extension is a type confusion. Fail with ParseError for non-scalar extensions. Repeated unknowns should go through PromoteUnknownToMessageArray. Signed-off-by: Paulo Cabral Sanz <ppaulo.sanz@gmail.com>
paulocsanz
force-pushed
the
pr-c003-promote-repeated
branch
from
August 20, 2026 03:05
4e48fae to
a8b43ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upb_Message_GetOrPromoteExtensionassertsCType == Messagebut does not check cardinality.The function stores a
upb_Message*in the extension slot. Repeated extensions are consumed asupb_Array*by the encoder and byGetExtensionMutableArray. Promoting a repeated message extension therefore confuses a message for an array.This change returns
kUpb_GetExtension_ParseErrorfor non-scalar extensions. Repeated unknowns should go throughupb_MiniTable_PromoteUnknownToMessageArray, which already exists and is covered byPromoteUnknownRepeatedMessageOld.Singular message extensions are unchanged (existing
promote_testcases plus a NotPresent control in the new test).