Skip to content

feat: Crash recovery salvage: persist verified candidate + resume (not rebuild) + orphan sweep .gN fix (#91)#96

Merged
mabry1985 merged 1 commit into
mainfrom
feat/bd-13w
Jul 23, 2026
Merged

feat: Crash recovery salvage: persist verified candidate + resume (not rebuild) + orphan sweep .gN fix (#91)#96
mabry1985 merged 1 commit into
mainfrom
feat/bd-13w

Conversation

@mabry1985

@mabry1985 mabry1985 commented Jul 23, 2026

Copy link
Copy Markdown
Member

Summary

Crash recovery salvage: persist verified candidate + resume (not rebuild) + orphan sweep .gN fix (#91) (bd-13w)

See the diff for details.

Fixes #91

@protoreview protoreview Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA panel review — PASS

code-review-structural · head 3e09c8af99e9 · formal

[review-synthesizer completed: workflow code-review-structural:report]

Prose Brief

Overall risk: Low — all four LLM finders returned zero findings, and the verifier confirmed the empty panel. The diff is a focused feature addition (sweep-based iteration in loop.py with a new parent_feature_id on Worktree) touching few files.

Fix-first item: None — no defects surfaced. However, the verifier flagged a coverage gap worth a human sanity check: worktree.parent_feature_id is referenced in loop.py's _sweep method but was not found in worktree.py on the default branch at verification time. This may live in a stacked/companion PR, but if it doesn't exist anywhere, the sweep feature silently breaks at runtime.

Panel disagreement: None — all four finders independently returned empty arrays.

Verification changes: The verifier confirmed the empty array; no refuted or uncertain items to process.

Gaps: (1) The structural pass (protopatch) failed with a context-length error — we have no tool-sourced findings for this round. (2) The parent_feature_id existence question noted above.

[]

@protoreview protoreview Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Promoting the PASS verdict for head 3e09c8af99e9: all checks terminal-green, zero unresolved review threads. (approve-on-green)

@mabry1985
mabry1985 merged commit 41bf0e1 into main Jul 23, 2026
1 check passed
@mabry1985
mabry1985 deleted the feat/bd-13w branch July 23, 2026 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash recovery discards fully-verified candidates — a kill between verify and open_pr rebuilds from scratch

1 participant