Conversation
Contributor
Author
|
All CI seems to pass now. Normally, when this runs on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some refactoring of the CI:
DockerfileintoDockerfile.riscv-toolchain.Dockerfile.riscv-toolchain, and only pushes to the registry on the main branch (or when triggered manually through aworkflow_dispatch, e.g.gh workflow run "Build RISC-V toolchain image" --ref ci-layers).Dockerfilenow uses the RISC-V toolchain image as base image.ci.ymlandreduced.ymlworkflows are now merged into a single workflow, with the intention of only having to declare each test once, even if they are used by both workflows. It instead uses conditional execution of certain steps of the workflows.Also fixed the Yosys build and pinned pywellen to an older version (will submit a PR with pywellen update soon).
Some parts are a bit vibe-coded, but it seems to work well from what I can tell.