util/sh: strip quotes when splitting build parameters - #412
Open
davidpavlovschi wants to merge 1 commit into
Open
util/sh: strip quotes when splitting build parameters#412davidpavlovschi wants to merge 1 commit into
davidpavlovschi wants to merge 1 commit into
Conversation
Signed-off-by: David PAVLOVSCHII <david.pavlovschii@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SplitParameterskept quoted sequences together but left the quotes in place, so a config withflags: -a -tags 'netgo static_build'passed the literal argument'netgo static_build'togo build. Double quotes were not recognized at all, so-gcflags="all=-N -l"split into two arguments.This replaces the regular expression with a small scanner that:
-gcflags="all=-N -l";The table-driven tests cover the reported
-tagscase, the double-quoted equivalent, attached quotes, and whitespace handling.Validation:
go test ./util/sh -run TestSplitParameters -count=1 -vgo test ./cmd/... ./pkg/... ./util/...go vet ./...make stylemake unusedmake lintThe full root-package test run also reaches two environment/pre-existing failures: the extldflags integration assertion reproduces on the clean base, and the crossbuild test requires Docker.
Fixes #172
@kakkoyun